| | | 1 | | using Elsa.Expressions.Contracts; |
| | | 2 | | using Elsa.Extensions; |
| | | 3 | | using Elsa.Workflows.Activities; |
| | | 4 | | using Elsa.Workflows.Management.Models; |
| | | 5 | | |
| | | 6 | | namespace Elsa.Workflows.Api.Security; |
| | | 7 | | |
| | 21 | 8 | | internal class WorkflowDefinitionScriptAuthorizationService( |
| | 21 | 9 | | IActivityVisitor activityVisitor, |
| | 21 | 10 | | IExpressionDescriptorRegistry expressionDescriptorRegistry) |
| | | 11 | | { |
| | 1 | 12 | | private static readonly ScriptPolicy[] ScriptPolicies = |
| | 1 | 13 | | [ |
| | 1 | 14 | | new( |
| | 1 | 15 | | "CSharp", |
| | 1 | 16 | | WorkflowScriptActivityTypeNames.RunCSharp, |
| | 1 | 17 | | "C# workflow expression execution is disabled by the host. Set CSharpOptions.AllowHostCodeExecution to true |
| | 1 | 18 | | new( |
| | 1 | 19 | | "Python", |
| | 1 | 20 | | WorkflowScriptActivityTypeNames.RunPython, |
| | 1 | 21 | | "Python.NET workflow expression execution is disabled by the host. Set PythonOptions.AllowHostCodeExecution |
| | 1 | 22 | | ]; |
| | | 23 | | |
| | | 24 | | public async Task<WorkflowDefinitionScriptAuthorizationResult> AuthorizeAsync(WorkflowDefinitionModel model, Cancell |
| | | 25 | | { |
| | 5 | 26 | | if (model.Root == null) |
| | 5 | 27 | | return WorkflowDefinitionScriptAuthorizationResult.Allowed(); |
| | | 28 | | |
| | 0 | 29 | | return await AuthorizeAsync(model.Root, cancellationToken); |
| | 5 | 30 | | } |
| | | 31 | | |
| | | 32 | | public async Task<WorkflowDefinitionScriptAuthorizationResult> AuthorizeAsync(IActivity root, CancellationToken canc |
| | | 33 | | { |
| | 14 | 34 | | var scriptUsages = await GetUsedScriptPoliciesAsync(root, cancellationToken); |
| | | 35 | | |
| | 14 | 36 | | var failure = scriptUsages |
| | 14 | 37 | | .Select(AuthorizeScriptUsage) |
| | 14 | 38 | | .FirstOrDefault(result => result is { Succeeded: false }); |
| | | 39 | | |
| | 14 | 40 | | if (failure.FailureReason.HasValue) |
| | 0 | 41 | | return failure; |
| | | 42 | | |
| | 14 | 43 | | return WorkflowDefinitionScriptAuthorizationResult.Allowed(); |
| | 14 | 44 | | } |
| | | 45 | | |
| | | 46 | | public async Task<WorkflowDefinitionScriptAuthorizationResult> AuthorizeAsync(Workflow workflow, CancellationToken c |
| | | 47 | | { |
| | 14 | 48 | | return await AuthorizeAsync((IActivity)workflow, cancellationToken); |
| | 14 | 49 | | } |
| | | 50 | | |
| | | 51 | | private WorkflowDefinitionScriptAuthorizationResult AuthorizeScriptUsage(ScriptPolicy policy) |
| | | 52 | | { |
| | | 53 | | // Language-specific options live in optional modules. Workflows.Api observes the descriptor state projected by |
| | 0 | 54 | | if (expressionDescriptorRegistry.Find(policy.ExpressionType)?.IsBrowsable != true) |
| | 0 | 55 | | return WorkflowDefinitionScriptAuthorizationResult.HostDisabled(policy.HostDisabledMessage); |
| | | 56 | | |
| | | 57 | | // The host switch is the only control, so there is nothing left to decide once it is on. The former |
| | | 58 | | // per-author permission conflated an incoherent execution-side gate -- a workflow runs under the |
| | | 59 | | // server's authority, not the caller's, so the check never constrained what a script could do -- |
| | | 60 | | // with a meaningful authoring-side one. Neither the caller nor a failure reason for a denied caller |
| | | 61 | | // is modelled here any more, because nothing produces one. Per-author script trust was considered and |
| | | 62 | | // declined in #7975, so this is the settled shape rather than a stop on the way to one. |
| | 0 | 63 | | return WorkflowDefinitionScriptAuthorizationResult.Allowed(); |
| | | 64 | | } |
| | | 65 | | |
| | | 66 | | private async Task<IEnumerable<ScriptPolicy>> GetUsedScriptPoliciesAsync(IActivity root, CancellationToken cancellat |
| | | 67 | | { |
| | 14 | 68 | | var graph = await activityVisitor.VisitAsync(root, cancellationToken); |
| | 14 | 69 | | var nodes = new[] { graph }.Concat(graph.Descendants()).ToList(); |
| | 14 | 70 | | var policies = ScriptPolicies |
| | 150 | 71 | | .Where(policy => nodes.Any(x => IsRunActivity(x.Activity, policy) || HasExpression(x.Activity, policy))) |
| | 14 | 72 | | .ToList(); |
| | | 73 | | |
| | 14 | 74 | | return policies; |
| | 14 | 75 | | } |
| | | 76 | | |
| | | 77 | | private static bool IsRunActivity(IActivity activity, ScriptPolicy policy) => |
| | 122 | 78 | | string.Equals(activity.Type, policy.RunActivityType, StringComparison.Ordinal); |
| | | 79 | | |
| | | 80 | | private static bool HasExpression(IActivity activity, ScriptPolicy policy) => |
| | 184 | 81 | | activity.GetInputs().Any(x => string.Equals(x.Expression?.Type, policy.ExpressionType, StringComparison.Ordinal) |
| | | 82 | | |
| | 186 | 83 | | private sealed record ScriptPolicy(string ExpressionType, string RunActivityType, string HostDisabledMessage); |
| | | 84 | | } |
| | | 85 | | |
| | | 86 | | internal readonly record struct WorkflowDefinitionScriptAuthorizationResult(bool Succeeded, WorkflowDefinitionScriptAuth |
| | | 87 | | { |
| | | 88 | | public static WorkflowDefinitionScriptAuthorizationResult Allowed() => new(true, null, null); |
| | | 89 | | |
| | | 90 | | public static WorkflowDefinitionScriptAuthorizationResult HostDisabled(string message) => new(false, WorkflowDefinit |
| | | 91 | | } |
| | | 92 | | |
| | | 93 | | internal enum WorkflowDefinitionScriptAuthorizationFailureReason |
| | | 94 | | { |
| | | 95 | | HostDisabled |
| | | 96 | | } |